Audit 380 guns #42718
Merged
Audit 380 guns #42718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Audit .380 caliber guns for volume, weight, and longest_side"
Purpose of change
Contribute to #37374 and #41691
Describe the solution
Update the JSON file the calculated values, from the method described in #37374
Describe alternatives you've considered
Cocktails, cocktails, cocktails.
Testing
Test suite passes. JSON validates. Guns spawn in-game with proper values.
Additional context
This should conclude the .380 caliber guns that were missing "longest_side".
Measurements are recorded here: https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit#gid=835787504&range=A2
FN 1910
There was no reliable source for the width of the weapon. Eventually, I found a top view image, edited away the stuff around it and measured the width of the slide. This is the value of 17.6 mm that went into width. Someone else might want to double check this, even though the weapon looks thin in the images.
https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit#gid=93328453&range=A46
Kel-Tec P3AT
https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit#gid=93328453&range=A78
Hi-Point CF-380
https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit#gid=93328453&range=A70
Taurus Spectrum
https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit#gid=93328453&range=A186